Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide on the usage of docker #1111

Merged
merged 44 commits into from
Jan 8, 2024
Merged

guide on the usage of docker #1111

merged 44 commits into from
Jan 8, 2024

Conversation

qingyun-wu
Copy link
Contributor

@qingyun-wu qingyun-wu commented Dec 31, 2023

Why are these changes needed?

Adding more comprehensive and better-structured documentation to guide the usage of docker

Related issue number

Closes #1096, partially addresses #1103

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40dbf31) 30.59% compared to head (7c49f31) 31.92%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   30.59%   31.92%   +1.33%     
==========================================
  Files          30       29       -1     
  Lines        4256     4097     -159     
  Branches      983      955      -28     
==========================================
+ Hits         1302     1308       +6     
+ Misses       2861     2695     -166     
- Partials       93       94       +1     
Flag Coverage Δ
unittests 31.87% <ø> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuandong-tian yuandong-tian self-requested a review January 1, 2024 04:03
@qingyun-wu qingyun-wu added docker documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jan 1, 2024
@qingyun-wu qingyun-wu marked this pull request as ready for review January 2, 2024 22:03
@qingyun-wu
Copy link
Contributor Author

The actual content of the dockefiles is subject to changes. Suggestions are welcomed!

Copy link
Member

@afourney afourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@olgavrou olgavrou mentioned this pull request Jan 4, 2024
3 tasks
Copy link
Collaborator

@yuandong-tian yuandong-tian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/Installation.md Outdated Show resolved Hide resolved
website/docs/Installation.md Outdated Show resolved Hide resolved
website/docs/Installation.md Outdated Show resolved Hide resolved
website/docs/Installation.md Outdated Show resolved Hide resolved
@sonichi sonichi requested a review from olgavrou January 6, 2024 01:42
qingyun-wu and others added 6 commits January 6, 2024 19:06
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with merging if we remove the docker command for autogen studio for now.

website/docs/Installation.md Outdated Show resolved Hide resolved
@qingyun-wu qingyun-wu added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 643a031 Jan 8, 2024
19 checks passed
@sonichi sonichi deleted the add-docker branch January 8, 2024 03:27
@r3d91ll r3d91ll mentioned this pull request Jan 14, 2024
3 tasks
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* docker documentation

* docker doc

* clean contribute.md

* minor change

* Add more detailed description

* add docker instructions

* more dockerfiles

* readme update

* latest python

* dev docker python version

* add version

* readme

* improve doc

* improve doc

* path name

* naming

* Update website/docs/Installation.md

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* Update website/docs/Installation.md

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* Add suggestion to install colima for Mac users

* Update website/docs/Installation.md

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* Update website/docs/Installation.md

Co-authored-by: olgavrou <olgavrou@gmail.com>

* update doc

* typo

* improve doc

* add more options in dev file

* contrib

* add link to doc

* add link

* Update website/docs/Installation.md

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* Update website/docs/Installation.md

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* instruction

* Update website/docs/FAQ.md

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* FAQ

* comment autogen studio

---------

Co-authored-by: Yuandong Tian <yuandong@fb.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Co-authored-by: olgavrou <olgavrou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Only the arm64 docker image is published to dockerhub
8 participants