-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guide on the usage of docker #1111
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
+ Coverage 30.59% 31.92% +1.33%
==========================================
Files 30 29 -1
Lines 4256 4097 -159
Branches 983 955 -28
==========================================
+ Hits 1302 1308 +6
+ Misses 2861 2695 -166
- Partials 93 94 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The actual content of the dockefiles is subject to changes. Suggestions are welcomed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with merging if we remove the docker command for autogen studio for now.
* docker documentation * docker doc * clean contribute.md * minor change * Add more detailed description * add docker instructions * more dockerfiles * readme update * latest python * dev docker python version * add version * readme * improve doc * improve doc * path name * naming * Update website/docs/Installation.md Co-authored-by: Chi Wang <wang.chi@microsoft.com> * Update website/docs/Installation.md Co-authored-by: Chi Wang <wang.chi@microsoft.com> * Add suggestion to install colima for Mac users * Update website/docs/Installation.md Co-authored-by: Chi Wang <wang.chi@microsoft.com> * Update website/docs/Installation.md Co-authored-by: olgavrou <olgavrou@gmail.com> * update doc * typo * improve doc * add more options in dev file * contrib * add link to doc * add link * Update website/docs/Installation.md Co-authored-by: Chi Wang <wang.chi@microsoft.com> * Update website/docs/Installation.md Co-authored-by: Chi Wang <wang.chi@microsoft.com> * instruction * Update website/docs/FAQ.md Co-authored-by: Chi Wang <wang.chi@microsoft.com> * FAQ * comment autogen studio --------- Co-authored-by: Yuandong Tian <yuandong@fb.com> Co-authored-by: Chi Wang <wang.chi@microsoft.com> Co-authored-by: olgavrou <olgavrou@gmail.com>
Why are these changes needed?
Adding more comprehensive and better-structured documentation to guide the usage of docker
Related issue number
Closes #1096, partially addresses #1103
Checks